-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use template-parameter and template parameter more consistently #7460
Merged
jensmaurer
merged 4 commits into
cplusplus:main
from
cor3ntin:corentin/template_argument_refactor
Jan 25, 2025
Merged
Use template-parameter and template parameter more consistently #7460
jensmaurer
merged 4 commits into
cplusplus:main
from
cor3ntin:corentin/template_argument_refactor
Jan 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wg21bot
added
the
needs rebase
The pull request needs a git rebase to resolve merge conflicts.
label
Dec 19, 2024
jensmaurer
requested changes
Dec 27, 2024
Try to use template-parameter only when we refer to a grammar construct, and to 'template parameter' everywhere else. Adopt the same logic to template-argument/template argument. This change might not be exhaustive. The aim is to editorially adopt some of the wording changes made in P2841R5 to ease its review in core.
cor3ntin
force-pushed
the
corentin/template_argument_refactor
branch
from
December 28, 2024 09:33
2a492dd
to
9fc22b5
Compare
jensmaurer
removed
the
needs rebase
The pull request needs a git rebase to resolve merge conflicts.
label
Jan 2, 2025
jensmaurer
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CWG off-line review from 2024-12-28 to 2025-01-23 passed with no comments. CWG was alerted of the merge in the 2025-01-24 telecon, with no objections.
@tkoeppe, do you have any final comments on this?
mizvekov
reviewed
Jan 24, 2025
Co-authored-by: Hubert Tong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to use template-parameter only when we refer to a grammar construct, and to 'template parameter' everywhere else.
Adopt the same logic to template-argument/template argument.
This change might not be exhaustive.
The aim is to editorially adopt some of the wording changes made in P2841R5 to ease its review in core.